Fix flaky Site Editor URL navigation e2e test #60675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
the
[Type] Automated Testing
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Mamaduka
commented
Apr 11, 2024
| await expect( page ).toHaveURL( | ||
| '/wp-admin/site-editor.php?postId=emptytheme%2F%2Fdemo&postType=wp_template_part&canvas=edit' | ||
| ); | ||
| test.beforeEach( async ( { requestUtils } ) => { |
There was a problem hiding this comment.
This is the actual fix. The rest is just minor cleanup. I've removed unnecessary grouping.
|
Size Change: 0 B Total Size: 1.75 MB ℹ️ View Unchanged
|
andrewserong
approved these changes
Apr 12, 2024
kevin940726
approved these changes
Apr 12, 2024
Using |
WunderBart
approved these changes
Apr 12, 2024
|
Thanks, everyone! |
|
The test is still flaky (#60678). Previously, it failed on the second run as well, and a report wasn't created. We can probably fix the flakiness by moving the deletion utility again, but there might be another cause for this. The original test was introduced a year ago, and it only recently became flaky. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
PR fixes flaky 'Redirection after template creation' e2e tests.
Why?
I noticed it failed a few times on GitHub, and then I could consistently reproduce it locally. The
Demotest post wasn't available based on failure traces.Recent failure report https://github.com/WordPress/gutenberg/actions/runs/8642543699
How?
I tried a few things, but using
test.beforeEachworks without a problem. Though I'm not entirely sure why 😅cc @kevin940726, @WunderBart
Testing Instructions