PHP unit test workflow: Try removing 7.0 and 7.1 #60686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewserong
added
[Type] Code Quality
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
ramonjd
approved these changes
Apr 12, 2024
andrewserong
added
[Type] Automated Testing
3 tasks
creativecoder
pushed a commit
that referenced
this pull request
May 2, 2024
Co-authored-by: andrewserong <[email protected]> Co-authored-by: ramonjd <[email protected]>
aaronjorbin
pushed a commit
that referenced
this pull request
May 2, 2024
Co-authored-by: andrewserong <[email protected]> Co-authored-by: ramonjd <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Try removing PHP 7.0 and PHP 7.1 from the suite of PHP unit tests in the Github workflow.
Why?
As of WordPress/wordpress-develop@d952352 WordPress 6.6 will no longer support PHP 7.0 and 7.1. As a result, the PHP unit tests workflow is currently failing with the following error:
Your server is running PHP version 7.0.33 but WordPress 6.6-alpha-57985 requires at least 7.2.24.Since our tests appear to run WordPress trunk, in order to get them passing again, I think we should try removing PHP 7.0 + 7.1 from this list. If it's desirable to retain those workflows, then we'd need to get them working again but run a version of WordPress < 6.6 in order for them to pass.
How?
Remove PHP 7.0 and 7.1 from the list of PHP versions in the PHP workflow
Testing Instructions
See if the PHP workflow passes now.