Background image: use media upload flow #60687
Conversation
Pulling across styles from editor package to block editor package (mostly duplicated)
ramonjd
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -482 B (0%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
|
I'm thinking the double image when both panels are open looks a bit garish. 
Perhaps we could use the current icon-like image preview and line the buttons up horizontally: 
|
Good point. I suppose one thing to consider before (or while) consolidating is how we might like to handle future controls such as setting the background of a Group block to 
Also, some plugins currently extend the list of options when adding media (i.e. to support other methods of adding images not covered in core), and we might want to support that kind of extensibility for the background image support in the future, too. What do you think? |
|
I appreciate the feedback @andrewserong!
True, I can see a featured image option being useful. In that case, the easiest option would be to keep what we've got since it's baked into the MediaReplaceFlow component. Or try to implement a combo for non-media-library functionality. In other words, the image preview would trigger the media library, and there'd be a drop down for extensibility options. 
🤷🏻 Happy to ditch this PR or whatever folks think.
I'd see that as a larger effort to use that type of filter across all media flows in Gutenberg for which I'd guess a bunch of refactoring would have be done anyway, e.g., reconsidering the drop down in case plugins add 10++ options. Hard to tell with such maybes. This would be a good point to keep in mind for any Media library redesign 😄 |
Good questions! I think if we don't really know what we'll need just yet, I'd lean toward keeping the (potential) duplication in the background support's controls to give us the flexibility to make further changes rather than re-using another component just yet. In case it helps for further explorations, looking at a test site on wordpress.com, I see they add the following to drop downs for the Image block: 
Let's see what @jameskoster thinks, too. I don't have any strong opinions on which direction we go, aside from the general idea that whatever we do at this stage, let's try to make it easy to change since the feature is still evolving 🙂 |
|
Oh! I nearly forgot - Also worth keeping in mind is a consolidation with gradient, which should probably be switched to use the What's more, If Gutenberg supports such things then the controls would, I expect, have to be bespoke. See #60401 (comment)
Yeah, thanks for raising it. I had that in mind when wondering what it would look like with 10++ options 😄 Would be nice to have that all integrated into a Media library window. |
💯 good thing to keep in the backs of our minds, for sure 😄 |
|
I think something may have gotten lost in translation, likely my fault, apologies! To clarify, I think the current control when the background image is set, is fine, this one: 
The one that we might tweak is the unset control, this one: 
At first glance the menu seems superfluous, but Andrew raised some excellent points about extensibility, and the ability to use the featured image. It may not be worth the effort, but I reckon if the menu is not extended, and it's not possible to use the featured image for some reason, then we could immediately open the media library rather than showing the menu in the screenshot above. I'll let y'all decide if that's worth it or not :) The other detail we might tweak is the preview thumbnail. When no image is set it doesn't add much value. If we removed that then we could essentially copy the UI found in the site logo block, IE: 
But again, this is a small detail, so if it's problematic to implement for any reason, then fine to leave as is! |
No apologies necessary. I often take something and run with it without stopping to reflect. Anyway, the experiment is done 😄
Oh, I can update #60264 with this change no worries. 👍🏻 I might close this then and concentrate on some of the trickier tasks on the backlog. Thanks again for the help and guidance, folks! |
What?
Replace media upload flow with featured image upload flow.
Pulling across featured image upload styles from editor package to block editor package (mostly duplicated).
Context: #60264 (comment)
Part of
Why?
Reduce clutter, make upload flows more consistent in the sidebar, fewer clicks
How?
See "What?"
Testing Instructions
Background image block support controls should be the same for Global styles (top-level) and blocks (Group block).
Test that:
Testing Instructions for Keyboard
Screenshots or screencast
2024-04-12.14.02.45.mp4