-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patterns: remove "Manage all parts" page & link #60689
Merged
Merged
Changes from 33 commits
Commits
Show all changes
37 commits
Select commit
Hold shift + click to select a range
9e59f77
Details page for parts: always go back to patterns
oandregal 2c120e5
Remove wp_template_part/all sidebar
oandregal de0226a
Remove wp_template_part/all content & preview frames
oandregal 943ac6c
Remove code to sync entity from URL params
oandregal c08064e
wp_template_part/all is no longer a page that exists
oandregal d3e095e
Remove link to Manage all Parts
oandregal 9c62807
Remove code for Parts in the Templates component
oandregal 1feaf09
Rename page class: from edit-site-page-template-template-parts-datavi…
oandregal 4d29772
Move page-templates-template-parts to page-templates
oandregal 3e015b0
/wp_template_part/all: load patterns sidebar
oandregal 6cb562b
Remove template part loading logic
oandregal 2be2331
Update e2e tests
oandregal 52cbb75
Fix import after rebase
oandregal 19ffef2
Fixup sidebar screen pattern
oandregal 6965ef9
Load the patterns screen for /wp_template_part/all
oandregal b5cee39
Use a generic copy that works for patterns & parts
oandregal fcd10be
Do not load pattern categories for block themes
oandregal e487f2d
Set category id & type properly when the path is /wp_template_part/all
oandregal 21af7ea
Content frame: set category id & type properly when the path is /wp_t…
oandregal 8bb9743
Go back to /wp_template_part/all for non-block based themes
oandregal 8212ac2
Use the existing page path (either /patterns or /wp_template_part/all
oandregal 1545f51
Revert changes to get-is-list-page
oandregal 4afe159
Revert changes to sync entity
oandregal 195b50d
Template sidebar: remove postType configuration
oandregal 2ea07e2
Hide actions for themes that are not block based
oandregal cc9d537
List patterns as well
oandregal 4143618
Fix backpath for non block based themes
oandregal 0a806db
Update Patterns sidebar
oandregal d7d8d4c
Fix backpath for Pattern sidebar
oandregal c635c42
Show actions when the path is not /wp_template_part/all
oandregal 45ee635
Non block based themes cannot create template parts
oandregal 627ded8
Update copy for /wp_template_part/all screen
oandregal 3c6aab9
Improve logic to show actions
oandregal 5192d86
Inline strings
oandregal 2dbe1c5
Document backpath
oandregal 08e8ebe
Do not render button if no actions
oandregal 18c6a0b
Revert back changes to content title copy
oandregal File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
62 changes: 0 additions & 62 deletions
62
packages/edit-site/src/components/page-templates-template-parts/add-new-template-part.js
This file was deleted.
Oops, something went wrong.
File renamed without changes.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason why you removed "all" from the title and the description fallback? I'm curious about the difference when opening "All patterns" and "All template parts" in the sidebar.
"Al template part" is selected:
"All patterns" is selected:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought about making these text the same for hybrid themes in the template parts screen so before/after is the same. Though I now realize it's best to leave them as they are. Reverted the changes at 18c6a0b