Interactivity: Ensure ignore directives are stable #60744
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +61 B (0%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
cbravobernal
added
the
[Type] Code Quality
sirreal
force-pushed
the
fix/stable-ignore-directives
branch
from
eebceb9 to
4634327
Compare
sirreal
force-pushed
the
fix/stable-ignore-directives
branch
from
61fe870 to
6a58170
Compare
|
Flaky tests detected in 6a58170. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/8740537904
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Ensure the ignore directive component is stable.
This requires WordPress/wordpress-develop#6405 or the tests will likely fail. Currently, the server processes directives on tags with
data-wp-ignoreand their descendants.Why?
The
ignoredirective should render a completely stable component, it should provide a DOM element that can be used that will not be rerendered or otherwise changed during its lifecycle. This allows developers to use the rendered DOM to reliably attach other behaviors, such as mounting a React component.It currently renders a component that updates if props change but leaves the
innerHTMLunchanged. It usesuseMemoto do that, which is documented in react as an optimization that is usually stable, but not reliably so. Preact is less clear about this, but other mechanisms may be better to ensure the stability of the DOM, such definingshouldComponentUpdate => falseas proposed.How?
Change the directive to a class Component with
shouldComponentUpdate(): false.Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast