Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NavigatorProvider: move the same-location check to the goTo function #60767

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

jsnajdr
Copy link
Member

@jsnajdr jsnajdr commented Apr 16, 2024

A tiny followup to #60561 that moves the new code to the goTo function. It maintains the structure of the reducer where all the work is done by the helper functions, and the reducer is just a command and control hub that assigns the work 🙂

@jsnajdr jsnajdr added [Type] Code Quality Issues or PRs that relate to code quality [Package] Components /packages/components labels Apr 16, 2024
@jsnajdr jsnajdr requested a review from youknowriad April 16, 2024 07:21
@jsnajdr jsnajdr self-assigned this Apr 16, 2024
@jsnajdr jsnajdr requested a review from ajitbohra as a code owner April 16, 2024 07:21
Copy link

github-actions bot commented Apr 16, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: jsnajdr <[email protected]>
Co-authored-by: youknowriad <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link

Flaky tests detected in aafbf89.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/8701563327
📝 Reported issues:

Copy link
Contributor

@youknowriad youknowriad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works for me.

@jsnajdr jsnajdr merged commit 69b7c6b into trunk Apr 16, 2024
66 of 67 checks passed
@jsnajdr jsnajdr deleted the update/goto-same-loc branch April 16, 2024 08:14
@github-actions github-actions bot added this to the Gutenberg 18.2 milestone Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Components /packages/components [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants