-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plugin: Bump minimum required WordPress version to 6.4 #60780
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
971dfdd
to
2583811
Compare
Do we say this anywhere? |
Note: If Performance tests start failing on the trunk after this is merged, you'll need to update the reference commit it workflow - https://developer.wordpress.org/block-editor/explanations/architecture/performance/#update-the-reference-commit |
Thank you for approving @ellatrix!
It's mentioned in the article that @Mamaduka shared (thanks!). Maybe we should also state it in a slightly more visible place though 🤔 |
Thank you! I can do that already as part of this PR. What about diff --git a/.github/workflows/performance.yml b/.github/workflows/performance.yml
index 02bdef381ce..74f331b95b7 100644
--- a/.github/workflows/performance.yml
+++ b/.github/workflows/performance.yml
@@ -68,13 +68,13 @@ jobs:
- name: Compare performance with base branch
if: github.event_name == 'push'
# The base hash used here need to be a commit that is compatible with the current WP version
- # The current one is 9bb75b35ec0daa46e8cd60c46619f522c7edd453 and it needs to be updated every WP major release.
+ # The current one is 9725060a5b18904c6cc5fdbe4b06fbde7419e02c and it needs to be updated every WP major release.
# It is used as a base comparison point to avoid fluctuation in the performance metrics.
run: |
WP_VERSION=$(awk -F ': ' '/^Tested up to/{print $2}' readme.txt)
IFS=. read -ra WP_VERSION_ARRAY <<< "$WP_VERSION"
WP_MAJOR="${WP_VERSION_ARRAY[0]}.${WP_VERSION_ARRAY[1]}"
- ./bin/plugin/cli.js perf $GITHUB_SHA 9bb75b35ec0daa46e8cd60c46619f522c7edd453 --tests-branch $GITHUB_SHA --wp-version "$WP_MAJOR"
+ ./bin/plugin/cli.js perf $GITHUB_SHA 9725060a5b18904c6cc5fdbe4b06fbde7419e02c --tests-branch $GITHUB_SHA --wp-version "$WP_MAJOR"
- name: Compare performance with custom branches
if: github.event_name == 'workflow_dispatch'
@@ -97,7 +97,7 @@ jobs:
CODEHEALTH_PROJECT_TOKEN: ${{ secrets.CODEHEALTH_PROJECT_TOKEN }}
run: |
COMMITTED_AT=$(git show -s $GITHUB_SHA --format="%cI")
- ./bin/log-performance-results.js $CODEHEALTH_PROJECT_TOKEN trunk $GITHUB_SHA 9bb75b35ec0daa46e8cd60c46619f522c7edd453 $COMMITTED_AT
+ ./bin/log-performance-results.js $CODEHEALTH_PROJECT_TOKEN trunk $GITHUB_SHA 9725060a5b18904c6cc5fdbe4b06fbde7419e02c $COMMITTED_AT
- name: Archive debug artifacts (screenshots, HTML snapshots)
uses: actions/upload-artifact@1746f4ab65b179e0ea60a494b83293b640dd5bba # v4.3.2
|
It makes changing the commit now. We'll have to do it at some point anyway. @youknowriad, do you mind double-checking the new proposed commit? It was merged today but meets both requirements. |
The commit works for me. |
We can also remove the 6.4 compat folder now, but we can do that in a separate PR. |
I'll add it! |
I think I'd prefer a separate PR if that's okay, so we don't keep adding to this one 😬 |
What?
Bumps the "Required WP version" field to 6.4, and the "Tested up to" field to 6.5.
This is somewhat related to https://core.trac.wordpress.org/ticket/60971.
Why?
Gutenberg's policy is to support the current major WordPress version (6.5.x), and the previous one (6.4.y).
How?
Simple replacements.
Testing Instructions
N/A