Restore classic auto margin rule to its previous specificity. #60802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tellthemachines
added
[Type] Bug
tellthemachines
requested review from
talldan,
ramonjd,
t-hamano and
aaronrobertshaw
|
Size Change: -2 B (0%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
andrewserong
approved these changes
Apr 18, 2024
ramonjd
approved these changes
Apr 18, 2024
|
Thanks for the reviews folks! |
|
Appreciate the quick fix and reviews everyone, nice work! 🙇 |
arthur791004
pushed a commit
that referenced
this pull request
Apr 18, 2024
Co-authored-by: tellthemachines <[email protected]> Co-authored-by: andrewserong <[email protected]> Co-authored-by: ramonjd <[email protected]> Co-authored-by: arthur791004 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes bug introduced in #60154 and reported here. Themes relying on this rule for editor styles might have seen some inadvertent changes with the specificity reduction.
Testing Instructions
Note: in testing this I noticed that the auto margin rule is causing a discrepancy between editor and front-end in the Details block on both Twenty Twenty and TT1, but that's likely due to those themes not having targeted styles for that block such as they do for older blocks like Columns. It remains an issue regardless of the specificity of this rule, so shouldn't be a blocker for this PR.
Testing Instructions for Keyboard
Screenshots or screencast