Site Editor: Close the editor sidebar by default #60820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
youknowriad
commented
Apr 17, 2024
| dispatch( interfaceStore ).setDefaultComplementaryArea( | ||
| 'core', | ||
| 'edit-site/template' | ||
| ); |
There was a problem hiding this comment.
What I actually don't understand is why the sidebar was closed by default before. Because this code was in place even before my refactoring :)
ellatrix
approved these changes
Apr 17, 2024
|
Size Change: -12 B (0%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
|
Mmm, this seems to break some e2e tests, so maybe it was not the default value that was wrong? |
youknowriad
force-pushed
the
update/close-sidebar-by-default-edit-site
branch
from
2208091 to
b491ff6
Compare
youknowriad
force-pushed
the
update/close-sidebar-by-default-edit-site
branch
from
46fce3a to
43043f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
After #60778 was merged, the sidebar in the site editor became "open" by default and it used to be closed. This resulted in the performance "typing" test running with sidebar closed which resulted in showing a performance regression (there wasn't any).
This PR marks the sidebar as closed by default like it used to be.