Make the zoom out inserters work for sections inside the section root #60909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
draganescu
changed the title
draganescu
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +18 B (0%) Total Size: 1.74 MB
ℹ️ View Unchanged
|
MaggieCabrera
approved these changes
Apr 19, 2024
|
I did note that these quick inserter render blocks when in a
|
|
@richtabor it's a known issue and it will have its own fix. There is a prop that these inserters can get to prioritise patterns but this prop is set internally depending on where the inserter is relative to the root element. The pattern assembler feature needs to update the above behaviour but it's unclear if we should: a) allow the prop to be set from outside |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
In zoom out mode there were some inserters appearing between top level blocks and this PR makes them appear back.
Why?
We changed how zoom out finds top level blocks by introducing the concept of section root, and the block inserters were not aware of this, looking always for the root element.
How?
Get the top blocks from the section root, whatever that is.
Testing Instructions
Testing Instructions for Keyboard
N/A
Screenshots or screencast
N/A