Select last section if parent section doesn't exist #61002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +8 B (0%) Total Size: 1.74 MB
ℹ️ View Unchanged
|
draganescu
added
[Type] Bug
draganescu
changed the title
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
scruffian
approved these changes
Apr 23, 2024
Mamaduka
approved these changes
Apr 23, 2024
There was a problem hiding this comment.
Thank you, @draganescu! The fix works as expected.
Note: The logic inside the mode === 'zoom-out' block is becoming a little bit hard to follow. It might be a time for minor refactoring + adding comments.
Mamaduka
previously requested changes
Apr 23, 2024
There was a problem hiding this comment.
I think I found another issue that seems to be related.
Steps to reproduce.
- Open the Site Editor.
- Open the Inserter > Patterns > Any category.
- Click on the canvas in Zoomed-out view.
- Notice that the Insert isn't closed, and the Patterns tab is missing.
- Toggle inserter.
- Notice that Media tab is also missing
Screenshot
CleanShot.2024-04-23.at.18.55.47.mp4
|
@scruffian, that sounds good. Could you add details on how it's different from the issue @draganescu resolved? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #60972
Why?
Selecting a category from the inserter patterns tab puts the editor in zoom out mode. Since in zoom out mode block selection is disabled and we default to "section" selection, we need to manage what is selected.
There is some logic to decide what to select in
__unstableSetEditorModewhich is an action in the block editor store, so when zoom out is activated:The bug in #60972 happens because we didn't consider that a selected block may have an undefined parent section (the root block doesn't).
How?
Fixes
__unstableSetEditorModeto also select the last section, if the currently selected block does not have a valid parent section.Testing Instructions
mainTesting Instructions for Keyboard
n/a
Screenshots or screencast
n/a
(*) "last root block", we expect that in a template we'd have a list of patterns or other grouped blocks, so if they're not in a
maingroup they're considered sections themselves.