[Mobile] - Remove circular dependencies within the components package #61102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
April 25, 2024 16:02
geriux
added
[Type] Enhancement
|
Size Change: 0 B Total Size: 1.75 MB ℹ️ View Unchanged
|
geriux
added
the
Mobile App - Automation
|
Flaky tests detected in 93b5efc. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/8881060435
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
twstokes
approved these changes
May 16, 2024
* Components - AutoComplete - Fix components imports * Components - ColorIndicator - Fix components imports * Components - ColorPicker - Fix components imports * Components - CustomGradient - Fix components imports * Components - DashIcon - Fix components imports * Components - Draggable - Fix components imports * Components - DropdownMenu - Fix components imports * Components - FocalPointPicker - Fix components imports * Components - FontSizePicker - Fix components imports * Components - AutoCompletion - Fix components imports * Components - BottomSheet - Fix components imports * Components - ColorSettings - Fix components imports * Components - FocalPointSettingsPanel - Fix components imports * Components - Gradient - Fix components imports * Components - Image - Fix components imports * Components - LinkPicker - Fix components imports * Components - LinkSettings - Fix components imports * Components - MediaEdit - Fix components imports * Components - Picker - Fix components imports * Components - Panel - Fix components imports * Components - QueryControls - Fix components imports * Components - SearchControl - Fix components imports * Components - Tooltip - Fix components imports Co-authored-by: geriux <[email protected]> Co-authored-by: twstokes <[email protected]>
geriux
removed
the
Mobile App - Automation
Merged
2 tasks
This was referenced May 17, 2024
|
Thanks for this @geriux 🙌 |
|
Thank you, @geriux! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs:
Addresses #52692
Second part #61109
What?
This PR addresses part of the circular dependencies the native editor has.
Why?
The initial prompt started at #27751 so this is a continuation of the ongoing effort to remove/reduce circular dependencies.
How?
By removing references from other components that would result in a circular dependency.
To make the review easier, this PR is split into two parts, the second part should be merged into this branch before merging.
Before these changes, we had 80 warnings of require cycles, with these two PRs we will have only 45 remaining, none of those are from the
componentspackage anymore so we can focus on the rest in future iterations.Changes
AudioPlayercomponent to the components of the Block Editor package where the VideoPlayer is currently located.componentspackage to have internal imports instead.Testing Instructions
CI checks should pass in both Gutenberg and Gutenberg Mobile.
Testing Instructions for Keyboard
N/A
Screenshots or screencast
NA