-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Components: Do not render FormTokenField label when not defined #61336
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@retrofox Looks good. Do not forget to add a components changelog entry and then this is ready to merge given checks pass.
b620926
to
dc0bf33
Compare
7a1b734
to
6e40825
Compare
6e40825
to
7674066
Compare
👍
I've added the entry, but the test still fails :-(
|
Flaky tests detected in 64a42b4. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/8981159903
|
@retrofox Just pushed a commit, let's see if that makes them pass. |
Thanks 🙇♂️ |
What?
Changes introduced this PR doesn't not rendering the label elements when the property value is not defined
Why?
Because currently, the component renders element with empty content
How?
It will render the label components only when the property is defined
Testing Instructions
Using storybook
http://localhost:50240/?path=/story/components-formtokenfield--default&args=label:
label
attributeTesting Instructions for Keyboard
Screenshots or screencast