Improve panel title and description for palette #61365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richtabor
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
richtabor
changed the title
|
Size Change: -1.25 kB (-0.07%) Total Size: 1.74 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 99e9aa6. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/8942392163
|
t-hamano
reviewed
May 4, 2024
| @@ -18,9 +18,9 @@ function ScreenColorPalette( { name } ) { | |||
| return ( | |||
| <> | |||
| <ScreenHeader | |||
| title={ __( 'Palette' ) } | |||
| title={ __( 'Edit Palette' ) } | |||
There was a problem hiding this comment.
Suggested change
| title={ __( 'Edit Palette' ) } | |
| title={ __( 'Edit palette' ) } |
I don't have a strong opinion about changing the text, but would it be better to unify it with sentence cases? (example
Edit template, Edit styles, etc.)
jasmussen
approved these changes
May 6, 2024
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
In support of #61213, changes "Palette" title for the ScreenHeader to be more relative to the activity in this panel, editing the palette. Also makes it clearer what the palette is via an updated description.
How?
Testing Instructions
Screenshots or screencast