-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PHP load: move rest template controller 6.6 import to "REST" area :) #61564
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From looking at the linked files added in #60317, it doesn't seem that the load order was a factor there, so this looks like a safe change to me! I see you've added @fabiankaegy as a reviewer, so and it'll be a very quick revert if there was a reason the original order was used.
Just left a tiny whitespace nit, but otherwise LGTM! 🚀
Thanks for checking @andrewserong The endpoints are initialized in the |
…bly best if it's loaded with the rest of the REST controllers.
Co-authored-by: Andrew Serong <[email protected]>
b5c18ff
to
d2a85f4
Compare
What?
WP_REST_Templates_Controller
extendsWP_REST_Controller
so it's probably best if it's loaded with the rest of the REST controllers.Testing Instructions
There are no functional changes here.
CI should pass and also templates should work/appear as you'd expected in the site editor.
Check PHP logs just in case.