Fix editor view mode canvas shadow #61688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stokesman
added
[Type] Code Quality
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -16 B (0%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
stokesman
commented
May 15, 2024
Comment on lines
-146
to
-149
|
|
||
| & > div { | ||
| border-radius: 0; | ||
| } |
There was a problem hiding this comment.
The radius shouldn’t have to be zeroed here (matching a .is-full-canvas selector) because radius is only applied when matching :not(.is-full-canvas)(L136).
stokesman
commented
May 15, 2024
| & > div { | ||
| .edit-site-resizable-frame__inner { |
There was a problem hiding this comment.
I'm not sure if we have guidelines on this but it seems like using the class can aid searches. This file already uses a few other classes that aren’t BEM elements of edit-site-layout so it’s not the only exception. I don’t know if that had to do with why > div was used.
jasmussen
approved these changes
May 16, 2024
|
Thanks for the review and test Joen ❤️ |
|
Thanks for the PR! 🙏 |
bph
pushed a commit
to bph/gutenberg
that referenced
this pull request
May 27, 2024
* Remove ineffectual shadow * Reapply shadow * Try a little cleanup Co-authored-by: stokesman <[email protected]> Co-authored-by: jasmussen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes a apparent regression of the canvas shadow in view mode of the editor. I didn’t label it regression because the label says that’s for latest release and I don’t know when this regressed.
Why?
The shadow is supposed to be there? I'd be just as happy to remove it as restore it but perhaps it would be more important were the editor to respect user admin themes (or become otherwise themeable).
How?
Moves the shadow to an element where it can be seen (if your eyesight and monitor are super good 😄).
Testing Instructions
Screenshots or screencast
Background color applied to make the difference easy to see.
Before
After