-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix long template name UI break issue #61703
base: trunk
Are you sure you want to change the base?
Fix long template name UI break issue #61703
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Thanks, @itzmekhokan! Can you share before and after screenshots in the PR description? It also helps to include testing instructions. |
@Mamaduka screenshot added for ref. |
Thanks for diving in here, we do need this one fixed. However I'm taking a bit of a different approach in #61492, allowing them to wrap onto two lines, but with better alignment and wrapping. I think we should do the same here. And the same feedback as was given on my PR probably applies: instead of adding classnames and custom CSS for those pieces, can we fix this at the component level? If you're able to do that, I'm happy to close my PR in favor of yours! 🙏 |
@jasmussen thanks for your suggestions. I have tried a better approch for component level updation and updated same in my PR. Please check it once. |
I wonder if 'Link' should truncate given it can potentially be very long and wrap onto several lines? |
I think there was some context on the link UI about not doing this. CC: @richtabor |
Because it can be very long, with just as much confidence that it is the correct link as just seeing the first X characters. As an aside, why is it titled "Link"? |
Fixes #61702
Screenshot
Before
After applying PR - #61703