Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ProgressBar
: Simplify defaultwidth
implementation and make it more easily overridable #61976ProgressBar
: Simplify defaultwidth
implementation and make it more easily overridable #61976Changes from 33 commits
023e5c4
b1fe7cd
fe9129d
64c72e2
c88ece0
ad0fff9
dc299ed
4c0b8fd
0ff6637
ad2fd28
adf39a1
ceb2840
9b3db94
a219fa8
1d22f24
b096ca4
3af0985
846ccc0
39b92a5
3241379
ff982fb
b0eca3f
59d46cc
0832e40
5ca947a
47183b7
eed1dba
d132170
43e1a57
7a00da3
a9c174b
66e8223
3a95761
a076910
2454c7a
981ce6f
67d97df
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not specific to this PR, but is there any reason we're not using
rem
almost everywhere? It is good practice for proper zoom support, which is an important accessibility feature. @WordPress/gutenberg-componentsThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've always assumed that this was a "that ship has sailed" situation, since WordPress/Gutenberg is already built entirely on a non-rem basis 😓