-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inserter: Update Openverse API URLs #62241
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@youknowriad, I wonder if we can get rid of this duplication now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would definitely be a good idea to do so.
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Please correct my understanding here. Does that mean old WP versions are broken now or does this only affect Gutenberg (and or tests) |
@youknowriad, the old domain will continue working for time being, at least until WP 6.6 is released. |
@youknowriad the domain redirection has been reverted, so nothing is currently broken. For the ~12hrs this redirect was in place, the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works in my testing 👍
Thanks for the explanations. Happy it's working for old versions too now.
Size Change: -6 B (0%) Total Size: 1.74 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works well in my testing, thanks @Mamaduka 👍
Co-authored-by: Mamaduka <[email protected]> Co-authored-by: youknowriad <[email protected]> Co-authored-by: tyxla <[email protected]> Co-authored-by: zackkrida <[email protected]>
I just cherry-picked this PR to the release/18.5 branch to get it included in the next release: 2b56a2c |
Co-authored-by: Mamaduka <[email protected]> Co-authored-by: youknowriad <[email protected]> Co-authored-by: tyxla <[email protected]> Co-authored-by: zackkrida <[email protected]>
Co-authored-by: Mamaduka <[email protected]> Co-authored-by: youknowriad <[email protected]> Co-authored-by: tyxla <[email protected]> Co-authored-by: zackkrida <[email protected]>
Co-authored-by: Mamaduka <[email protected]> Co-authored-by: youknowriad <[email protected]> Co-authored-by: tyxla <[email protected]> Co-authored-by: zackkrida <[email protected]>
Co-authored-by: Mamaduka <[email protected]> Co-authored-by: youknowriad <[email protected]> Co-authored-by: tyxla <[email protected]> Co-authored-by: zackkrida <[email protected]>
This was cherry-picked to the wp/6.6 branch. |
What?
PR updates media category URLs for Openverse.
Why?
The old https://api.openverse.engineering/ began redirecting to https://api.openverse.org/ today, causing an infinite loading state in the editors and e2e test failure.
See the full discussion on Slack (requires login).
Testing Instructions
Testing Instructions for Keyboard
Same.
Screeenshot