Image Block: Show image blocks with external URLs and support resizing #6240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Type] Bug
youknowriad
force-pushed
the
fix/image-block-with-external-url
branch
from
a52a1a3 to
468a764
Compare
|
Nice! works for me 👍 👍 |
|
👍 code looks good. Thanks for fixing that up, Riad! |
noisysocks
reviewed
Apr 18, 2018
| @@ -221,84 +219,85 @@ class ImageBlock extends Component { | |||
|
|
|||
| const isResizable = [ 'wide', 'full' ].indexOf( align ) === -1 && ( ! viewPort.isExtraSmall() ); | |||
|
|
|||
| const getInspectorControls = ( imageWidth, imageHeight )=> ( | |||
There was a problem hiding this comment.
Huh, weird that the linter didn't complain about the missing space here.
nuzzio
pushed a commit
to nuzzio/gutenberg
that referenced
this pull request
Apr 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related #5812
This PRs fixes the image block when using an external URL (the images were not showing) and also adds resizing support using the inspector controls to these images.
Testing instructions