-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Invalid link on explanations documentation. #62487
Fix: Invalid link on explanations documentation. #62487
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
The section itself seems to exist. However, when I click on this link on the Explanations page, I go to the following URL and the page is not found. Perhaps if we remove the slash after the extension ( diff --git a/docs/explanations/README.md b/docs/explanations/README.md
index 04d9f8e9e1..2d0da6cabd 100644
--- a/docs/explanations/README.md
+++ b/docs/explanations/README.md
@@ -8,5 +8,5 @@
- [Block Editor Performance](/docs/explanations/architecture/performance.md).
- What are the decision decisions behind the Data Module?
- [Why is Puppeteer the tool of choice for end-to-end tests?](/docs/explanations/architecture/automated-testing.md)
-- [What’s the difference between the different editor packages? What’s the purpose of each package?](/docs/explanations/architecture/modularity.md/#whats-the-difference-between-the-different-editor-packages-whats-the-purpose-of-each-package)
+- [What’s the difference between the different editor packages? What’s the purpose of each package?](/docs/explanations/architecture/modularity.md#whats-the-difference-between-the-different-editor-packages-whats-the-purpose-of-each-package) |
b8ad96d
to
9f4cb6a
Compare
You are totally right @t-hamano, I noticed the modularity.md file had changed but I missed that the section was still there at the bottom. I fixed the link as suggested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Co-authored-by: jorgefilipecosta <[email protected]> Co-authored-by: t-hamano <[email protected]>
The section "What’s the difference between the different editor packages? What’s the purpose of each package?" does not exist anymore but the link to it was kept.
This PR removes the invalid link.