Block bindings: Change bindings panel title, add description. #62489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbravobernal
requested review from
jasmussen,
richtabor,
artemiomorales and
SantosGuillamot
SantosGuillamot
approved these changes
Jun 11, 2024
There was a problem hiding this comment.
Code-wise, it looks good to me. And it seems to be working. I'll defer the approval to the people involved in the original conversation to ensure we are aligned in the title and the help text.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +525 B (+0.03%) Total Size: 1.76 MB
ℹ️ View Unchanged
|
cbravobernal
changed the title
|
Looks good. Let's tweak the help text slightly per feedback. It could say, outside of better suggestions: "Connected attributes connected to different sources."
That would also avoid the typographic widow. |
Are we repeating the word connected too much in that sentence? |
Right, we certainly are. Sorry, I hadn't gotten enough coffee. The important part here is to avoid the typographic widow. So if we go with the original intent, we either have to add a word, or remove a word, so it fits on one line. The idea here is that on the second line, there should be at least two words. This can also be addressed by adding |
|
How about this: "Attributes connected to various sources." |
That one looks much better, thanks @jasmussen |
cbravobernal
added
the
Backport to WP 6.7 Beta/RC
patil-vipul
pushed a commit
to patil-vipul/gutenberg
that referenced
this pull request
Jun 17, 2024
…ess#62489) * Change title, add description * Update description * Update description Co-authored-by: cbravobernal <[email protected]> Co-authored-by: SantosGuillamot <[email protected]> Co-authored-by: jasmussen <[email protected]>
29 tasks
ellatrix
pushed a commit
that referenced
this pull request
Jun 18, 2024
* Change title, add description * Update description * Update description Co-authored-by: cbravobernal <[email protected]> Co-authored-by: SantosGuillamot <[email protected]> Co-authored-by: jasmussen <[email protected]>
ellatrix
pushed a commit
that referenced
this pull request
Jun 18, 2024
* Change title, add description * Update description * Update description Co-authored-by: cbravobernal <[email protected]> Co-authored-by: SantosGuillamot <[email protected]> Co-authored-by: jasmussen <[email protected]>
|
I just cherry-picked this PR to the wp/6.6-beta-3 branch to get it included in the next release: a95c451 |
ellatrix
added
Backported to WP Core
ellatrix
pushed a commit
that referenced
this pull request
Jun 18, 2024
* Change title, add description * Update description * Update description Co-authored-by: cbravobernal <[email protected]> Co-authored-by: SantosGuillamot <[email protected]> Co-authored-by: jasmussen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Issue related: #61404
Trying to improve the developer experience by changing the title and adding a description as this comment.
#61404 (comment)
Screenshots or screencast