Add margin-bottom lint rules for CheckboxControl, ComboboxControl, SearchControl #63679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
49 tasks
|
Size Change: +4 B (0%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
mirka
commented
Jul 17, 2024
There was a problem hiding this comment.
Testing instructions
Toggle the block inserter in the top left, and select the Media tab. Choose one of the options to display the search panel. The margin below the search field should be maintained at 16px (normal viewport width), and 24px (mobile viewport width).
There was a problem hiding this comment.
Testing instructions
In Gutenberg Experiments (wp-admin/admin.php?page=gutenberg-experiments), enable the "Form and input blocks" experiment. In the block editor, insert a Form block and click on one of the text fields to show the block inspector.
There was a problem hiding this comment.
Testing instructions
Insert a Page List block and show the block inspector.
The excessive bottom margin is slightly corrected:
| Before | After |
|---|---|
 |
 |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
ciampo
approved these changes
Jul 18, 2024
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Jul 18, 2024
…archControl (WordPress#63679) Co-authored-by: mirka <[email protected]> Co-authored-by: ciampo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #38730
What?
Adds eslint rules to prevent new instances of the following components to be introduced in the Gutenberg codebase without the
__nextHasNoMarginBottomprop being added:Why?
These lint rules should prevent new violating usages from being added, until we are ready to officially deprecate the margins on the BaseControl-based components all at once.
Testing Instructions
See code comments.