Fix the post summary Status toggle button accessibility #63988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afercia
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +10 B (0%) Total Size: 1.78 MB
ℹ️ View Unchanged
|
afercia
force-pushed
the
fix/post-summary-panel-accessibility
branch
from
4e3b56e to
6764872
Compare
|
Flaky tests detected in 6764872. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/10665851864
|
|
Thank you @Mamaduka for your review 👋🏽 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses a few points reported in #63308
What?
The button to open the 'Status & visibility' popover has an aria-label attribute
Change post status: %swhere the termpostis hardcoded. This should be removed as this setting is used for pages and CPTs as well.The button missies an aria-expanded attribute.
Why?
Minor improvement for accessibility and consistency.
How?
post.aria-expandedattribute to the Status toggle button.Testing Instructions
Change status: %.Testing Instructions for Keyboard
Screenshots or screencast