Font Library Modal: Group font variations as a list #64029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: 0 B Total Size: 1.78 MB ℹ️ View Unchanged
|
t-hamano
force-pushed
the
font-library-modal/tweak-font-list
branch
from
d1994dc to
3609500
Compare
t-hamano
force-pushed
the
font-library-modal/tweak-font-list
branch
from
3609500 to
0d5a379
Compare
|
Screenshot of Safari and VoiceOver correctly announcing the total items and item position:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #58834
What?
This PR groups fonts as a list in the following two screens:
Font Library Modal > Library Tab > Select a font
Font Library Modal > Install Fonts Tab > Select a font
Why?
The current font variation screen only displays a list of button elements, so screen reader users have no way of knowing how many fonts are displayed.
How?
Similar to #58834, wrap each font in a list item element and wrap those in a list element.
Testing Instructions
This PR is just a markup change and should not change anything in behavior or appearance. If you want to check the differences between files, this split view will be easy to understand.
Testing Instructions for Keyboard
list with 2 items ABeeZee Normal check box not checked