Data views: Fix actions scrim in list layout #64696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameskoster
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +75 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
jasmussen
approved these changes
Aug 22, 2024
|
I spotted that too. It's because the buttons are hidden using absolute positioning, and repositioned to be visible when the row is hovered. But for some reason the hover class is removed when you cursor out of the browser. If you have a moment it would be good to open a separate issue. cc @oandregal for awareness, iirc you worked on this. |
bph
pushed a commit
to bph/gutenberg
that referenced
this pull request
Aug 31, 2024
Co-authored-by: jameskoster <[email protected]> Co-authored-by: jasmussen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In data views list layout, actions are positioned absolutely and there's a subtle shadow to 'truncate' titles when the actions appear on hover/focus-within:
There is currently a bug with the implementation. When you open the ellipsis menu, the hover styles are not applied to the row, and the shadow becomes visible independently:
Note: You may have to increase screen brightness to see the issue.
This PR fixes this by ensuring the hover styles remain applied when the ellipsis menu is opened.
Testing Instructions