Remove “Columns” slider from Columns block #64722
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stokesman
added
[Type] Enhancement
|
Size Change: -823 B (-0.05%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
richtabor
requested changes
Aug 22, 2024
There was a problem hiding this comment.
You want to remove the columns count control from the columns block?
I'm fairly confident this is not the correct solution to #9009 and would be cited as a regression. Otherwise, if you don't start with the correct column count, then you're out of luck.
I change column counts all the time without that slider. Also, I don’t want to debate semantics, but this is a UI change and there’s no regression in features. Columns can still be added and removed. Your disapproval is noted. Requesting changes falsely is a bit much but perhaps that was a mistaken click. No way this was going to get irresponsibly approved and merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
An alternative solution to the old pitfall where the "Columns" slider deletes content within columns.
Why?
To resolve #9009 with the least technical challenge and the upside of obviating a bunch of code.
How?
Removes the problematic control.
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast
columns-no-slider.mov