Global Styles: Allow referenced zero value and simplify getValueFromObjectPath calls #64836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronrobertshaw
added
[Type] Code Quality
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
aaronrobertshaw
changed the title
|
Size Change: -11 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
ramonjd
approved these changes
Aug 27, 2024
bph
pushed a commit
to bph/gutenberg
that referenced
this pull request
Aug 31, 2024
…bjectPath calls (WordPress#64836) Co-authored-by: aaronrobertshaw <[email protected]> Co-authored-by: ramonjd <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
A few minor code quality tweaks for global styles util functions.
Why?
Bottle pickup during an exploration into style inheritance.
How?
getValueFromObjectPathcan accept a string or array for the object path. Let the function do its thing to make the consumer code a touch more concise.refvalues by explicitly checking forundefined. This allows referenced integer zero values.The existing unit tests already have coverage related to the calls to
getValueFromObjectPathin the affected utils. A new test case was added forgetResolvedRefValueto ensure referenced zero integer values were successfully returned.Testing Instructions
i. Add a zero integer value for a block type's padding in theme.json
ii. Define a style for a second block type or padding side that references the zero integer value
iii. Load up global styles and ensure that the reference zero value displays
Screenshots or screencast