Site Editor: Remove unused 'useSiteEditorSettings' hook #64892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Code Quality
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -38 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
ramonjd
approved these changes
Aug 29, 2024
bph
pushed a commit
to bph/gutenberg
that referenced
this pull request
Aug 31, 2024
) Co-authored-by: Mamaduka <[email protected]> Co-authored-by: ramonjd <[email protected]>
|
Cool :) |
dcalhoun
added a commit
to wordpress-mobile/GutenbergKit
that referenced
this pull request
Dec 17, 2024
This largely reverts #24, which resulted in several regressions. Namely, oddities in the block toolbar emptying and empty Patterns/Media tabs in the block inserter. The previous changes was implemented to workaround an experimental API that is no longer exported after WordPress/gutenberg#64892. That remains an issue, but the new workaround is to patch Gutenberg itself to export this necessary API with `patch-package`.
dcalhoun
added a commit
to wordpress-mobile/GutenbergKit
that referenced
this pull request
Dec 17, 2024
This largely reverts #24, which resulted in several regressions. Namely, oddities in the block toolbar emptying and empty Patterns/Media tabs in the block inserter. The previous changes was implemented to workaround an experimental API that is no longer exported after WordPress/gutenberg#64892. That remains an issue, but the new workaround is to patch Gutenberg itself to export this necessary API with `patch-package`.
dcalhoun
added a commit
to wordpress-mobile/GutenbergKit
that referenced
this pull request
Dec 17, 2024
This largely reverts #24, which resulted in several regressions. Namely, oddities in the block toolbar emptying and empty Patterns/Media tabs in the block inserter. The previous changes was implemented to workaround an experimental API that is no longer exported after WordPress/gutenberg#64892. That remains an issue, but the new workaround is to patch Gutenberg itself to export this necessary API with `patch-package`.
dcalhoun
added a commit
to wordpress-mobile/GutenbergKit
that referenced
this pull request
Dec 17, 2024
This largely reverts #24, which resulted in several regressions. Namely, oddities in the block toolbar emptying and empty Patterns/Media tabs in the block inserter. The previous changes was implemented to workaround an experimental API that is no longer exported after WordPress/gutenberg#64892. That remains an issue, but the new workaround is to patch Gutenberg itself to export this necessary API with `patch-package`.
dcalhoun
added a commit
to wordpress-mobile/GutenbergKit
that referenced
this pull request
Dec 17, 2024
This largely reverts #24, which resulted in several regressions. Namely, oddities in the block toolbar emptying and empty Patterns/Media tabs in the block inserter. The previous changes was implemented to workaround an experimental API that is no longer exported after WordPress/gutenberg#64892. That remains an issue, but the new workaround is to patch Gutenberg itself to export this necessary API with `patch-package`.
dcalhoun
added a commit
to wordpress-mobile/GutenbergKit
that referenced
this pull request
Dec 18, 2024
* build: Add patch-package * build: Configure patch-package * fix: Replace unsupported editor architecture This largely reverts #24, which resulted in several regressions. Namely, oddities in the block toolbar emptying and empty Patterns/Media tabs in the block inserter. The previous changes was implemented to workaround an experimental API that is no longer exported after WordPress/gutenberg#64892. That remains an issue, but the new workaround is to patch Gutenberg itself to export this necessary API with `patch-package`. * fix: Disable interception `blob:` URLs leading to an Android crash While the reason for why the `blob:` requests trigger is unknown, they originate when utilizing the block inserter's Patterns tab. The requests seemingly originate from the embedded editor previews rendered for each pattern.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
PR removes the unused
useSiteEditorSettingshook from thecore/edit-sitepackage. I've also removeduseBlockEditorSettingsexported as private API.Why?
The hook hasn't been used since #62146.
Testing Instructions
CI checks should be green.
Testing Instructions for Keyboard
Same.