-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Composite: add context-forwarding with SlotFill example #65051
Composite: add context-forwarding with SlotFill example #65051
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great and tests well! 🚀
Thanks for building a story for this elaborate use case, @ciampo 🙌
Wow, good call to document this 🙇 Thank you. Also TIL |
I did while working with
I wonder if we should have a more systematic approach to it:
|
Yes, I think we could very well do all the things you listed! It's a tricky thing that could waste a lot of time to figure out. |
What?
Extracted from #64723
Add a new "With Slot Fill" Storybook example for the
Composite
componentWhy?
To better showcase the utility of the
Composite.Context
component, especially as we're planning on obfuscating the type of thestore
prop on the context.How?
Testing Instructions
Screenshots or screencast