Block Bindings: Add background color to bound blocks #65199
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artemiomorales
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Some notes:
|
|
Size Change: +30 B (0%) Total Size: 1.78 MB
ℹ️ View Unchanged
|
|
Nice, thanks for trying this. I can conform your befores/afters:
The focus style is unchanged, as it should be. One note, I think of this styling option not as a background color for the block (which is causing the contrast note to appear), but as UI decoration just like focus styles. I also wonder if this color should be visible only when the block is selected. 🤔 We can also try 10% opacity instead: This color change alone isn't meant to be the primary or even only signifier of dynamism. |
|
That may work for paragrahps.
|
|
Yep, as a small update, this was a bit of a failed experiment, though I appreciate you trying the idea, Artemio! I'm working on an alternative approach in #65233, which still isn't fully coming together, need to take another stab at it. |
|
Let's close this experiment then on favor of #65233. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This adds a background color to bound blocks.
Why?
We'd like to visually indicate when blocks are bound.
How?
It adds an inline style inside
use-block-props, where other global bindings styles are set.Testing Instructions
1. Register post meta by adding this snippet to your theme's functions.php
Testing Instructions for Keyboard
Screenshots or screencast
Before
After