Navigator Screen: warn if path doesn't follow a URL-like scheme #65231
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Add a runtime check in
NavigatorScreen
to warn consumers when thepath
prop doesn't follow the expected formatWhy?
When the expected format is not used,
Navigator
doesn't behave as expected (see, for example, #65109). A runtime check is one more way that we can help consumers ofNavigator
to use the component as expected.How?
If the
path
doesn't start with/
, output a warning to console.Testing Instructions
In dev mode, in the editor try changing the
path
of aNavigatorScreen
component and remove the leading/
— a warning should be printed to console.The new unit test should pass.