Block Bindings: Remove key fallback in bindings get values and rely on source label #65517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SantosGuillamot
added
[Type] Bug
SantosGuillamot
requested review from
gziolo,
artemiomorales and
cbravobernal
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -8 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
gziolo
approved these changes
Sep 20, 2024
SantosGuillamot
deleted the
fix/remove-key-fallback-in-bindings-get-values
branch
github-actions
bot
removed
the
Backport to WP 6.7 Beta/RC
gutenbergplugin
pushed a commit
that referenced
this pull request
Sep 20, 2024
…n source label (#65517) * Always fall back to source label * Adapt e2e tests Co-authored-by: SantosGuillamot <[email protected]> Co-authored-by: gziolo <[email protected]>
|
I just cherry-picked this PR to the wp/6.7 branch to get it included in the next release: 4baca3e |
github-actions
bot
added
the
Backported to WP Core
kevin940726
pushed a commit
that referenced
this pull request
Sep 23, 2024
…n source label (#65517) * Always fall back to source label * Adapt e2e tests Co-authored-by: SantosGuillamot <[email protected]> Co-authored-by: gziolo <[email protected]>
|
I just cherry-picked this PR to the release/19.3 branch to get it included in the next release: 814d35c |
kevin940726
removed
the
Backport to Gutenberg RC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
It removes the fallback to the
args.keywhengetValuesdoesn't exist. This is the case of sources registered only in the server, for example.Why?
As explained here, In that pull request, we stopped treating the
args.keyas a special argument and rely only on the label, which is always provided by the source. It seems it wasn't removed from this part of the code.How?
I just removed the fallback to the key and relied on the server source. Additionally, I changed the e2e tests to reflect that.
Testing Instructions
args.key: