InspectorControlsSlot: remove unused framer motion context forwarding #67522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
ciampo
added
[Type] Code Quality
|
Size Change: -29 B (0%) Total Size: 1.83 MB
ℹ️ View Unchanged
|
tyxla
approved these changes
Dec 3, 2024
| @@ -1,11 +1,8 @@ | |||
| /** | |||
| * WordPress dependencies | |||
| */ | |||
| import { | |||
| __experimentalUseSlotFills as useSlotFills, | |||
| __unstableMotionContext as MotionContext, | |||
There was a problem hiding this comment.
Now that we removed the last usage, I think this is a good time to remove the unstable MotionContext re-export:
Looks like there's no usage in plugins:
https://wpdirectory.net/search/01JE66GHXATVJHR1K7PQQG074W
Can be done in a separate PR IMHO.
There was a problem hiding this comment.
I'm always hesitant about removing APIs, but that should be OK given that there are no usages.
jsnajdr
reviewed
Dec 3, 2024
packages/block-editor/src/components/inspector-controls/slot.js
Outdated
Show resolved
Hide resolved
ciampo
force-pushed
the
cleanup/remove-framer-motion-context-forwarding
branch
from
31b5711 to
07ddcb6
Compare
|
Flaky tests detected in 07ddcb6. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12178770117
|
michalczaplinski
pushed a commit
that referenced
this pull request
Dec 5, 2024
…#67522) * InspectorControlsSlot: remove unused framer motion context forwarding * Remove computedFillProps, use fillProps directly --- Co-authored-by: ciampo <[email protected]> Co-authored-by: tyxla <[email protected]> Co-authored-by: jsnajdr <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Stop forwarding Framer Motion's context in the inspector controls SlotFill
Why?
The forwarding was introduced in #50278, but shouldn't be necessary anymore after refactoring
ToggleGroupControlandTabsaway fromframer-motion.Removing unnecessary lines of code and runtime computation is always a good idea.
How?
Deleted the relevant lines of code.
Testing Instructions
Smoke tests a few different block controls in the inspector controls, make sure that they all work as expected, especially any framer-motion-based animation (if any).