Menu granular subcomponents: Refactor dataviews table layout header menu #67640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
ciampo
requested review from
oandregal,
jorgefilipecosta,
ntsekouras and
a team
ciampo
added
[Type] Task
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
tyxla
approved these changes
Dec 9, 2024
| </Button> | ||
| } | ||
| style={ { minWidth: '240px' } } | ||
| // align="start" TODO: align prop doesn't exist on Menu — is it ok to just remove |
There was a problem hiding this comment.
I think it's fine, I don't see a difference by removing it. I don't see such a prop in Ariakit's Menu API either. Maybe this was a bad copy/pasta?
|
Tested the menu actions still work as expected. Code changes look good. As with the other PR, I see some weird UI things, but it affects other Menu (not yet refactored): 
|
@oandregal: @ciampo is splitting the changes into multiple PRs, so the idea is to review the affected parts per-piece only, ignoring the oddities outside of the PR's focus. So the oddities you're seeing are expected. Once merged into #67422, we'll review and test thoroughly again, and there should be no oddities. |
ciampo
merged commit 37c9e53
into
feat/menu-granular-trigger-components
33 of 39 checks passed
ciampo
deleted the
feat/menu-granular-components/dataviews-table-header
branch
ciampo
added a commit
that referenced
this pull request
Dec 12, 2024
…enu (#67640) Co-authored-by: ciampo <[email protected]> Co-authored-by: tyxla <[email protected]> Co-authored-by: oandregal <[email protected]>
ciampo
added a commit
that referenced
this pull request
Dec 13, 2024
…enu (#67640) Co-authored-by: ciampo <[email protected]> Co-authored-by: tyxla <[email protected]> Co-authored-by: oandregal <[email protected]>
ciampo
added a commit
that referenced
this pull request
Dec 16, 2024
…enu (#67640) Co-authored-by: ciampo <[email protected]> Co-authored-by: tyxla <[email protected]> Co-authored-by: oandregal <[email protected]>
ciampo
added a commit
that referenced
this pull request
Dec 16, 2024
* MenuItem: add render and store props * Extract sub-components: popover, trigger button, submenu trigger item * Unit tests * CHANGELOG * Add more memory to node on CI * Refactor block bindings panel menu (#67633) Co-authored-by: ciampo <[email protected]> * Storybook (#67632) * Refactor dataviews item actions menu (#67636) * Refactor dataviews view config menu (#67637) * Refactor global styles shadows edit panel menu (#67641) * Refactor global styles font size menus (#67642) * Refactor "Add filter" dataviews menu (#67634) * Menu granular subcomponents: Refactor dataviews list layout actions menu (#67639) Co-authored-by: ciampo <[email protected]> Co-authored-by: tyxla <[email protected]> Co-authored-by: oandregal <[email protected]> * Menu granular subcomponents: Refactor dataviews table layout header menu (#67640) Co-authored-by: ciampo <[email protected]> Co-authored-by: tyxla <[email protected]> Co-authored-by: oandregal <[email protected]> * Menu granular subcomponents: Refactor post actions menu (#67645) Co-authored-by: ciampo <[email protected]> Co-authored-by: tyxla <[email protected]> * Better comments for submenu trigger store * Typo * Remove unnecessary MenuSubmenuTriggerItemProps type * Don't break the rules of hooks 🪝 * Move CHANGELOG entry to unreleased section * Add explicit MenuProps to improve TS performance * Remove node memory settings --------- Co-authored-by: ciampo <[email protected]> Co-authored-by: tyxla <[email protected]> Co-authored-by: mirka <[email protected]> Co-authored-by: oandregal <[email protected]>
yogeshbhutkar
pushed a commit
to yogeshbhutkar/gutenberg
that referenced
this pull request
Dec 18, 2024
* MenuItem: add render and store props * Extract sub-components: popover, trigger button, submenu trigger item * Unit tests * CHANGELOG * Add more memory to node on CI * Refactor block bindings panel menu (WordPress#67633) Co-authored-by: ciampo <[email protected]> * Storybook (WordPress#67632) * Refactor dataviews item actions menu (WordPress#67636) * Refactor dataviews view config menu (WordPress#67637) * Refactor global styles shadows edit panel menu (WordPress#67641) * Refactor global styles font size menus (WordPress#67642) * Refactor "Add filter" dataviews menu (WordPress#67634) * Menu granular subcomponents: Refactor dataviews list layout actions menu (WordPress#67639) Co-authored-by: ciampo <[email protected]> Co-authored-by: tyxla <[email protected]> Co-authored-by: oandregal <[email protected]> * Menu granular subcomponents: Refactor dataviews table layout header menu (WordPress#67640) Co-authored-by: ciampo <[email protected]> Co-authored-by: tyxla <[email protected]> Co-authored-by: oandregal <[email protected]> * Menu granular subcomponents: Refactor post actions menu (WordPress#67645) Co-authored-by: ciampo <[email protected]> Co-authored-by: tyxla <[email protected]> * Better comments for submenu trigger store * Typo * Remove unnecessary MenuSubmenuTriggerItemProps type * Don't break the rules of hooks 🪝 * Move CHANGELOG entry to unreleased section * Add explicit MenuProps to improve TS performance * Remove node memory settings --------- Co-authored-by: ciampo <[email protected]> Co-authored-by: tyxla <[email protected]> Co-authored-by: mirka <[email protected]> Co-authored-by: oandregal <[email protected]>
yogeshbhutkar
pushed a commit
to yogeshbhutkar/gutenberg
that referenced
this pull request
Dec 18, 2024
* MenuItem: add render and store props * Extract sub-components: popover, trigger button, submenu trigger item * Unit tests * CHANGELOG * Add more memory to node on CI * Refactor block bindings panel menu (WordPress#67633) Co-authored-by: ciampo <[email protected]> * Storybook (WordPress#67632) * Refactor dataviews item actions menu (WordPress#67636) * Refactor dataviews view config menu (WordPress#67637) * Refactor global styles shadows edit panel menu (WordPress#67641) * Refactor global styles font size menus (WordPress#67642) * Refactor "Add filter" dataviews menu (WordPress#67634) * Menu granular subcomponents: Refactor dataviews list layout actions menu (WordPress#67639) Co-authored-by: ciampo <[email protected]> Co-authored-by: tyxla <[email protected]> Co-authored-by: oandregal <[email protected]> * Menu granular subcomponents: Refactor dataviews table layout header menu (WordPress#67640) Co-authored-by: ciampo <[email protected]> Co-authored-by: tyxla <[email protected]> Co-authored-by: oandregal <[email protected]> * Menu granular subcomponents: Refactor post actions menu (WordPress#67645) Co-authored-by: ciampo <[email protected]> Co-authored-by: tyxla <[email protected]> * Better comments for submenu trigger store * Typo * Remove unnecessary MenuSubmenuTriggerItemProps type * Don't break the rules of hooks 🪝 * Move CHANGELOG entry to unreleased section * Add explicit MenuProps to improve TS performance * Remove node memory settings --------- Co-authored-by: ciampo <[email protected]> Co-authored-by: tyxla <[email protected]> Co-authored-by: mirka <[email protected]> Co-authored-by: oandregal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
In the context of #67422, refactor the
Menucomponent used in the header of the table layout in the dataviews packageWhy?
See #67422
How?
Refactor usages of the
Menucomponent. See #67422 for more details on how to refactor from the old to the new APIs.Testing Instructions
/wp-admin/site-editor.php?p=%2Fpage&layout=table(visiting the link is necessary because the layout switcher dropdown menu is being refactored in a separate PR and therefore won't work in this PR)Note
Note that test failures and potential build/runtime errors are expected while the various PR extracted from #67422 (as the current one) are not merged back into #67422 yet.