DataViews: Handle grid preview size based on container width
#68078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
[Type] Bug
ntsekouras
requested review from
mcsf,
oandregal,
jameskoster,
jasmussen and
jorgefilipecosta
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
ntsekouras
commented
Dec 18, 2024
|
Size Change: +100 B (+0.01%) Total Size: 1.84 MB
ℹ️ View Unchanged
|
ntsekouras
force-pushed
the
dataviews/handle-grid-preview-size-with-container-width
branch
from
8633f00 to
fd3f68b
Compare
|
Flaky tests detected in f0997cc. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12393102831
|
ntsekouras
force-pushed
the
dataviews/handle-grid-preview-size-with-container-width
branch
from
fd3f68b to
f0997cc
Compare
jameskoster
approved these changes
Dec 18, 2024
ntsekouras
deleted the
dataviews/handle-grid-preview-size-with-container-width
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Currently in
gridlayout for DataViews we adjust the preview size based on viewport width. This is wrong and you can see that in Storybook - make sure to change togridlayout.This PR handles that by using the container width, which is also passed as part of DataViews context for any consumer.
Also related to: #68030, which tries DataViews inside the inserter.
Testing Instructions
gridlayout (example in templates page) in various widths (by resizing the viewport).npm run storybook:dev) and check DataViewsgridlayout in various containers