-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Storybook: Add story for the Warning component #68124
Storybook: Add story for the Warning component #68124
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Hey @t-hamano, Could you please review my PR for adding the story for the Warning component? I used the README.md as a solid reference to create the story. Looking forward to your feedback! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
I think it's important for this component to show how the actions
prop and secondaryActions
prop are displayed. For example, see the story of the Notice component. For example, you should be able to define multiple stories like this:
export const WithActions = {
args: {
...Default.args,
actions: [
<Button key="fix-issue" __next40pxDefaultSize variant="primary">
{ __( 'Fix issue' ) }
</Button>,
],
},
};
export const WithSecondaryActions = {
args: {
...Default.args,
secondaryActions: [
{ title: __( 'Get help' ) },
{ title: __( 'Remove block' ) },
],
},
};
packages/block-editor/src/components/warning/stories/index.story.js
Outdated
Show resolved
Hide resolved
packages/block-editor/src/components/warning/stories/index.story.js
Outdated
Show resolved
Hide resolved
@t-hamano , Please check again; I have made the requested changes. Screen.Recording.2024-12-23.at.6.02.57.PM.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Part of #67165
What?
This PR adds the Storybook stories for the Warning component in the block editor.
Testing Instructions
Screenshots or screencast
Screen.Recording.2024-12-19.at.2.03.53.PM.mov