Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wp-env: Add phpMyAdmin and multisite support to the documentation #68125

Merged
merged 7 commits into from
Jan 21, 2025
Merged

wp-env: Add phpMyAdmin and multisite support to the documentation #68125

merged 7 commits into from
Jan 21, 2025
+24 −14

Conversation

t-hamano
Copy link
Contributor

Related to #67588, #67845

What?

Add documentation for the new support recently added in the env package (phpMyAdmin, Multisite).

Why?

For developers

How?

I have updated two files that I thought needed updating. Any suggestions for wording corrections are welcome.

Testing Instructions

None

@t-hamano t-hamano added the [Type] Developer Documentation Documentation for developers label Dec 19, 2024
@t-hamano t-hamano self-assigned this Dec 19, 2024
@t-hamano t-hamano requested review from mcsf and youknowriad December 19, 2024 08:52
@t-hamano t-hamano marked this pull request as ready for review December 19, 2024 08:52
@t-hamano t-hamano added the [Tool] Env /packages/env label Dec 19, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 19, 2024 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: t-hamano <[email protected]>
Co-authored-by: mcsf <[email protected]>
Co-authored-by: spacedmonkey <[email protected]>
Co-authored-by: fabiankaegy <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 19, 2024 •
edited
Loading

Flaky tests detected in 8d50403.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12607366805
📝 Reported issues:

mcsf
mcsf approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@mcsf mcsf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much, @t-hamano! I've preemptively approved this but left some suggestions.

packages/env/README.md Outdated Show resolved Hide resolved
packages/env/README.md Outdated Show resolved Hide resolved
docs/contributors/code/getting-started-with-code-contribution.md Outdated Show resolved Hide resolved
packages/env/README.md Outdated Show resolved Hide resolved
@t-hamano t-hamano changed the title wp-env: Added phpMyAdmin and multisite support to the documentation wp-env: Add phpMyAdmin and multisite support to the documentation Jan 4, 2025
fabiankaegy
fabiankaegy approved these changes Jan 20, 2025
View reviewed changes
Copy link
Member

@fabiankaegy fabiankaegy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding these docs :)

@spacedmonkey spacedmonkey mentioned this pull request Jan 20, 2025
Merged
@spacedmonkey
Copy link
Member

Releated #68792

@t-hamano t-hamano merged commit 39ed61d into trunk Jan 21, 2025
65 checks passed
@t-hamano t-hamano deleted the docs/update-env-readme branch January 21, 2025 01:27
@github-actions github-actions bot added this to the Gutenberg 20.2 milestone Jan 21, 2025
Gulamdastgir-Momin pushed a commit to Gulamdastgir-Momin/gutenberg that referenced this pull request Jan 23, 2025
@t-hamano @mcsf
@spacedmonkey @fabiankaegy @Gulamdastgir-Momin
wp-env: Add phpMyAdmin and multisite support to the documentation (Wo…
818bb1f 
…rdPress#68125)

* wp-env: Added phpMyAdmin and multisite support to the documentation

* Fix double periods

Co-authored-by: Miguel Fonseca <[email protected]>

* Improve description of phpmyadminPort

Co-authored-by: Miguel Fonseca <[email protected]>

* Clarify explanation about phpMyAdmin and mysql ports

Co-authored-by: Miguel Fonseca <[email protected]>

* Add a line break

* Updated the description of phpMyAdmin

---------

Co-authored-by: t-hamano <[email protected]>
Co-authored-by: mcsf <[email protected]>
Co-authored-by: spacedmonkey <[email protected]>
Co-authored-by: fabiankaegy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabiankaegy fabiankaegy fabiankaegy approved these changes

@spacedmonkey spacedmonkey spacedmonkey approved these changes

@mcsf mcsf mcsf approved these changes

@youknowriad youknowriad Awaiting requested review from youknowriad

@ObliviousHarmony ObliviousHarmony Awaiting requested review from ObliviousHarmony ObliviousHarmony is a code owner

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

@juanmaguitar juanmaguitar Awaiting requested review from juanmaguitar juanmaguitar is a code owner

@ndiego ndiego Awaiting requested review from ndiego ndiego is a code owner

Assignees

@t-hamano t-hamano

Labels
[Tool] Env /packages/env [Type] Developer Documentation Documentation for developers
Projects
None yet
Milestone
Gutenberg 20.2
Development

Successfully merging this pull request may close these issues.
4 participants
@t-hamano @spacedmonkey @mcsf @fabiankaegy