Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DropZone: Make the drop zone in Storybook the same size as the item #68231

Merged
merged 3 commits into from
Dec 23, 2024

Conversation

t-hamano
Copy link
Contributor

What?

By adding position:relative to the parent element, make the size of the drop zone component match the size of the item.

At the same time, increase the padding a bit because it was a bit cramped when we were about to drop it.

Testing Instructions

Access http://localhost:50240/?path=/story/components-dropzone--default

Screenshots or screencast

Before

before.mp4

After

after.mp4

@t-hamano t-hamano requested a review from a team December 23, 2024 02:57
@t-hamano t-hamano marked this pull request as ready for review December 23, 2024 02:57
@t-hamano t-hamano requested a review from ajitbohra as a code owner December 23, 2024 02:57
@t-hamano t-hamano self-assigned this Dec 23, 2024
Copy link

github-actions bot commented Dec 23, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: t-hamano <[email protected]>
Co-authored-by: tyxla <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@t-hamano t-hamano added [Type] Code Quality Issues or PRs that relate to code quality [Package] Components /packages/components Storybook Storybook and its stories for components labels Dec 23, 2024
Copy link

github-actions bot commented Dec 23, 2024

Flaky tests detected in 92cb3a3.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12467023853
📝 Reported issues:

Copy link
Member

@tyxla tyxla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me 👍

packages/components/CHANGELOG.md Outdated Show resolved Hide resolved
@t-hamano t-hamano merged commit d678c3a into trunk Dec 23, 2024
62 checks passed
@t-hamano t-hamano deleted the drop-zone-storybook branch December 23, 2024 13:32
@github-actions github-actions bot added this to the Gutenberg 20.0 milestone Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Components /packages/components Storybook Storybook and its stories for components [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants