Update: Bundle upload media. #68522
Merged
Update: Bundle upload media. #68522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
added
the
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -826 B (-0.04%) Total Size: 1.84 MB
ℹ️ View Unchanged
|
jorgefilipecosta
force-pushed
the
update/bundle-upload-media
branch
from
4178de6 to
a2e95b5
Compare
jorgefilipecosta
requested review from
ajitbohra,
juanmaguitar,
fabiankaegy and
ndiego
as code owners
|
Flaky tests detected in 732945e. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12652593436
|
jsnajdr
reviewed
Jan 7, 2025
package-lock.json
Outdated
| "packages/block-editor/node_modules/@wordpress/upload-media": { | ||
| "resolved": "packages/token-list", | ||
| "link": true | ||
| }, |
There was a problem hiding this comment.
This is a very strange record that shouldn't be there. Why is the upload-media package linked to the packages/token-list folder?
My PR (#68528) has this record that places the package in the top-level node_modules folder and links correctly:
"node_modules/@wordpress/upload-media": {
"resolved": "packages/upload-media",
"link": true
},
There was a problem hiding this comment.
Good catch it should be fixed.
packages/upload-media/package.json
Outdated
| @@ -1,7 +1,6 @@ | |||
| { | |||
| "name": "@wordpress/upload-media", | |||
| "version": "1.0.0-prerelease", | |||
There was a problem hiding this comment.
Let's change the version to 0.0.1, that's a semver way to say that the package is unstable.
jorgefilipecosta
force-pushed
the
update/bundle-upload-media
branch
2 times, most recently
from
ac86584 to
3c35e8b
Compare
|
Hi @jsnajdr, thank you for the review, I applied your feedback. |
westonruter
added a commit
that referenced
this pull request
Jan 7, 2025
…ry/interactivity-lazy-hydration * 'trunk' of https://github.com/WordPress/gutenberg: (143 commits) Update: Bundle upload media. (#68522) Add: Media field changing ui to Dataviews and content preview field to posts and pages (#67278) Bump the react-native group with 2 updates (#68095) Check Storybook build on CI for PRs (#68466) Bump the github-actions group across 1 directory with 2 updates (#68436) Classic theme preview: remove admin-bar class name (#68519) Remove geriux as code owner (#68523) Post Featured Image: Adds control to clear the the overlay color (#68525) Components: Standardize reduced motion handling using media queries (#68421) Upgrade Playwright to v1.49 (#68504) Document Outline: Use block client ID as unique 'key' (#68502) Storybook: Add UnitControl story (#67346) Details: Add allowedBlocks and TemplateLock attributes (#68489) Post Comment Link: Show Border Control By Default (#68506) Query Total: Show Border Controls By Default (#68507) RSS: Added Colour support (#66419) Refactor: Separate input form styles to a dedicated stylesheet (#68501) Code quality: Fix typos (#67304) Page List: Added color support (#66430) Fix flaky DataViews list arraow nav e2e tests (#68503) ...
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
@wordpress/upload-mediapackage was referenced in theBlockEditorProvider. But is not published and is not declared as a dependency this will make any package relying on block editor and using the provider failing to build e.g: plugins because they can not resolve the package.This PR tries to make the
@wordpress/upload-mediaa private bundled package.