-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix flaky navigation-frontend-interactivity e2e tests #68667
Conversation
Flaky tests detected in 7419d61. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12780055700
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @t-hamano!
Let's give it a try. There are no failures in five runs.
Co-authored-by: t-hamano <[email protected]> Co-authored-by: Mamaduka <[email protected]>
Alternatives to #68643
What?
Trying to solve the flaky tests in
navigation-frontend-interactivity.spec.js
:How?
As mentioned in this comment, this may be because the canvas loader disappears very early. As a fallback, wait for the editor canvas instead of the canvas loader.
Testing Instructions
Let's see if the E2E tests are stable and successful.