[WP6.7] Keep meta boxes unsplit from content in device previews #68902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
stokesman
changed the title
|
Size Change: +109 B (+0.01%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
t-hamano
added
[Type] Bug
t-hamano
approved these changes
Jan 28, 2025
There was a problem hiding this comment.
To test this PR, I fixed the lint errors and re-merged the wp/6.7 branch (See #68886). With this PR, the editor canvas and meta boxes will no longer overlap.
I think it would be a good idea to ship this PR in 6.7, what do you think?
|
I agree that this would be good to get in 6.7 especially since the fix has now been included in multiple versions of Gutenberg. |
I was a little hasty resolving the conflict 😅. Thanks for the fix-up.
The fix that’s been in Gutenberg is different (#66706) and might indicate it is the more tested one. Anyway, I have equal confidence in them and defer to other contributors on which should go in 6.7. |
|
I would like to merge this PR. Both this PR and #66706 work fine, but merging #66706 would have a big impact on users. That is, the regular meta boxes would be changed to the resizable meta boxes in the legacy canvas. This change will of course happen in WP 6.8, but I would like to adopt this PR as it has less impact for a minor release. |
This was referenced Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Avoids obscured device previews when meta boxes are present in the Post editor.
Why?
Fixes #66629 minimally with the solution proposed by Aki from the issue.
How?
Makes device previews a condition for displaying the meta boxes as they are when the canvas is not iframed and revises styling so there’s a no clipping of the fixed canvas height of device previews.
Testing Instructions
Device previews
Desktop view
Ensure the split view works as before:
Testing Instructions for Keyboard
Screenshots or screencast
meta-boxes-device-previews-same-scrolling-area.mp4