-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Embed: use 100% width for iframe. #995
Conversation
mtias
commented
Jun 2, 2017
Works well for me! 👍 |
Do you anticipate the generic width rule to have issues elsewhere? |
No, not width. Height, perhaps, but none that I can think of. |
Ok, will merge. |
I think https://github.com/WordPress/gutenberg/tree/master/components/responsive-wrapper (Should write some docs 😄 ) |
@aduth should we use Storybook or write our own devdocs like calypso? |
@youknowriad Would be interesting to explore, certainly. I think now that things have started to settle a bit more and documentation is clearly a pain point of past JavaScript in core, we have some good opportunities to showcase automated documentation. This is where I'm starting to go with #989, hoping to turn it into a function reference for eventual integration into the WordPress code reference. Something to what we did with Selectors DevDocs. We should probably reach out to the Documentation team to start coordinating too. |