Skip to content
This repository has been archived by the owner on Aug 4, 2023. It is now read-only.

airflow dockerfile: set PYTHONPATH to DAGs folder #514

Merged
merged 1 commit into from
May 20, 2022
Merged

airflow dockerfile: set PYTHONPATH to DAGs folder #514

merged 1 commit into from
May 20, 2022

Conversation

tal66
Copy link
Contributor

@tal66 tal66 commented May 19, 2022

Fixes

Fixes WordPress/openverse#1564 by @AetherUnbound

Description

Adds the DAGs folder to the PYTHONPATH within the Docker container.

Testing Instructions

Per WordPress/openverse#1564, run:

  1. just shell
  2. python -c "from common import storage"
  3. Observe that no ModuleNotFoundError exception is raised.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@tal66 tal66 requested a review from a team as a code owner May 19, 2022 14:52
@tal66 tal66 requested review from AetherUnbound and stacimc May 19, 2022 14:52
@openverse-bot openverse-bot added 🛠 goal: fix Bug fix 🟩 priority: low Low priority and doesn't need to be rushed 🤖 aspect: dx Concerns developers' experience with the codebase labels May 19, 2022
@AetherUnbound
Copy link
Contributor

Thanks for the contribution @tal66! I've edited your PR description so it aligns with our template. I'm having some trouble testing this locally, but I have a feeling it's something on my end.

@AetherUnbound
Copy link
Contributor

I'm going to rebase this to include the changes from #502 and make sure it still passes CI

Copy link
Contributor

@AetherUnbound AetherUnbound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, works great with the test commands!

@AetherUnbound AetherUnbound merged commit 7dbff46 into WordPress:main May 20, 2022
@zackkrida
Copy link
Member

Hi @tal66 if you ever want to chat about Openverse and contributing more, we have a community Slack channel (#openverse) in the Making WordPress Slack Instance. You can learn how to join here, if you're interested:

https://make.wordpress.org/chat/

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🤖 aspect: dx Concerns developers' experience with the codebase 🛠 goal: fix Bug fix 🟩 priority: low Low priority and doesn't need to be rushed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DAGs folder is not present in PYTHONPATH
5 participants