Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Sensitive content filter #2153

Closed
wants to merge 48 commits into from
Closed

Sensitive content filter #2153

wants to merge 48 commits into from

Conversation

anton202
Copy link
Contributor

@anton202 anton202 commented Feb 7, 2023

Fixes

Related to WordPress/openverse#636 by @panchovm

Description

This PR creates a Toggle switch and a new senesetive content filter
senesetive-content

Checklist

  • My pull request has a descriptive title (not a vague title like
    Update index.md).
  • My pull request targets the default branch of the repository (main) or
    a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible
    errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@anton202 anton202 requested a review from a team as a code owner February 7, 2023 14:44
feat/feature-flags.json Outdated Show resolved Hide resolved
feat/feature-flags.json Outdated Show resolved Hide resolved
Copy link
Member

@zackkrida zackkrida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is phenomenal work! I love the new toggle component.

One thing we will need to fix, however, is accessibility. We need some focus styles for the toggle. Right now I can't tell if it can be switched using the keyboard or not.

@panchovm do you know if we have focus styles for this toggle yet? This may be blocked by that design work if not.

Thanks so much @anton202.

@anton202
Copy link
Contributor Author

anton202 commented Feb 10, 2023

@zackkrida @olga thank you for your comments and changes and thx for correcting my english in evrey PR :)))
i`ll commit zack`s chaanges on sunday.
regarding accessibility, never really addreessed accessibility stuff before. so as you mentioned, i`ll add the ability to switch the toggle button using the keyboard.
regading the focus style, of course if @panchovm have an answear for it that will be great, but any way i`ll check in the design library that i took this switch toggle from (i think it was from wordpress design library)

@fcoveram
Copy link

The toggle element used in Openverse is the one from the WordPress Design Library. So please use that one and replace the focus color with openverse pink.

image

I also noticed that this ticket addresses a component change. Not sure if it covers the toggle element but worth checking its scope. In any case, we need to follow the last version of WordPress' toggle component.

@anton202 anton202 marked this pull request as draft February 15, 2023 16:26
@anton202 anton202 marked this pull request as ready for review February 21, 2023 11:52
@anton202 anton202 closed this by deleting the head repository Mar 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🕹 aspect: interface Concerns end-users' experience with the software 🌟 goal: addition Addition of new feature 🟨 priority: medium Not blocking but should be addressed soon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants