-
Notifications
You must be signed in to change notification settings - Fork 63
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is phenomenal work! I love the new toggle component.
One thing we will need to fix, however, is accessibility. We need some focus styles for the toggle. Right now I can't tell if it can be switched using the keyboard or not.
@panchovm do you know if we have focus styles for this toggle yet? This may be blocked by that design work if not.
Thanks so much @anton202.
@zackkrida @olga thank you for your comments and changes and thx for correcting my english in evrey PR :))) |
The toggle element used in Openverse is the one from the WordPress Design Library. So please use that one and replace the focus color with openverse I also noticed that this ticket addresses a component change. Not sure if it covers the toggle element but worth checking its scope. In any case, we need to follow the last version of WordPress' toggle component. |
Co-authored-by: Zack Krida <[email protected]>
Co-authored-by: Zack Krida <[email protected]>
Fixes
Related to WordPress/openverse#636 by @panchovm
Description
This PR creates a Toggle switch and a new senesetive content filter
Checklist
Update index.md
).main
) ora parent feature branch.
errors.
Developer Certificate of Origin
Developer Certificate of Origin