Set dir="rtl" conditionally on content pages based on translation %
#601
Labels
💻 aspect: code
Concerns the software code in the repository
✨ goal: improvement
Improvement to an existing user-facing feature
🟨 priority: medium
Not blocking but should be addressed soon
🧱 stack: frontend
Related to the Nuxt frontend
Comments
zackkrida
added
🟩 priority: low
7 tasks
krysal
added
🟨 priority: medium
dhruvkb
pushed a commit
that referenced
this issue
Apr 14, 2023
* same tests new names plus some for new methods * the refactored script * comment clean-up * make get_next_query_params parameters consistent Co-authored-by: Staci Cooper <[email protected]> * Mark incremental endpoint as a property that doesn't need parameters Co-authored-by: Staci Cooper <[email protected]> * Add new class to provider workflows list * Use next params to increment page number * remove redundant constants * remove import from Cleveland script * Simplify page counter * standard get_media_type parameter Co-authored-by: Staci Cooper <[email protected]> * the actual API has a top layer and the list is under results Co-authored-by: Staci Cooper <[email protected]> * Backing out over-simplified page counter * add testing for a real full_response.json * Improve API description * Add get should continue logic * json linting * Removing single redundant line :( * Improve title transformation Co-authored-by: Krystle Salazar <[email protected]> * Update link format to include title and id Co-authored-by: Krystle Salazar <[email protected]> * remove unnecessary testing comment * update tests for new title and foreign landing url * make license info a class var Co-authored-by: Staci Cooper <[email protected]> Co-authored-by: Krystle Salazar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Problem
Currently, content pages have
dir="ltr"set manually, because rtl language translations don't exist for these pages.Description
We should set up these pages to set the
dirattribute conditionally based on the % of completed translation for the current language.The text was updated successfully, but these errors were encountered: