Create the page for sensitive content explanation #3074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openverse-bot
added
🟨 priority: medium
|
Size Change: +40.1 kB (+4%) Total Size: 932 kB
ℹ️ View Unchanged
|
…nsitive_content_page
AetherUnbound
approved these changes
Sep 30, 2023
Comment on lines
26
to
29
| <!-- TODO | ||
| <h2 id="on-off">{{ $t("sensitive.onOff.title") }}</h2> | ||
| <p>{{ $t("sensitive.onOff.description", { openverse: "Openverse" }) }}</p> | ||
| --> |
There was a problem hiding this comment.
Should this still be TODO?
There was a problem hiding this comment.
I kept this as TODO as this is a TODO in the reference Google doc. Alternatively I can write it directly in the PR and we can iterate on it here?
|
Good catch @AetherUnbound, thank you! Updated the link in e4be495. |
obulat
requested changes
Oct 5, 2023
Co-authored-by: Olga Bulat <[email protected]>
obulat
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes #2550 by @dhruvkb
Description
This PR adds the page for explanation about sensitive content and our filtering techniques.
Testing Instructions
/sensitive-content./preferencesand turn onsensitive_contentandfake_sensitiveflags./sensitive-contentpage again.Checklist
Update index.md).main) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin