Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefix standalone plugins with 'PL' in list table and add plugin row meta link to Performance Lab settings screen #1052

Closed
wants to merge 2 commits into from

Conversation

westonruter
Copy link
Member

Summary

See #1046. When the PL plugin is active, this prefixes all installed standalone plugins with PL so that they appear grouped together. A "Performance Lab" plugin row meta link is also added which points to the settings screen.

Performance Lab Deactivated Performance Lab Activated
localhost_8888_wp-admin_plugins php_plugin_status=all paged=1 s localhost_8888_wp-admin_plugins php

Relevant technical choices

The all_plugins filter is employed to loop overall installed plugins, and if any one matches one of the standalone plugin slugs, it prefixes the Name with "PL". After this, the plugins are re-sorted so that the PL plugins appear together.

Also, the plugin row meta is filtered for the standalone plugins so that a "Performance Lab" link is added for the plugin's settings screen.

@westonruter westonruter added [Type] Enhancement A suggestion for improvement of an existing feature Infrastructure Issues for the overall performance plugin infrastructure labels Mar 13, 2024
@westonruter westonruter added this to the PL Plugin 3.0.0 milestone Mar 13, 2024
Copy link

github-actions bot commented Mar 13, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: westonruter <[email protected]>
Co-authored-by: felixarntz <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link
Member

@felixarntz felixarntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a fan of the "PL" prefix. This is as if "Jetpack Boost" was called "JP Boost". When you see one of those plugins, you probably wouldn't know what it means.

Anyway, let's wait for the decision in #1046 before considering a change like this. Potentially we'll want to change the plugin names themselves instead, in which case this wouldn't be relevant.

@westonruter
Copy link
Member Author

"Jetpack" is much shorter than "Performance Lab" so it makes more sense to not abbreviate.

Anyway, this PR is a POC to assist with the discussion of what the possibilities are.

@westonruter westonruter marked this pull request as draft March 13, 2024 18:30
@ThierryA
Copy link
Member

"Jetpack" is much shorter than "Performance Lab" so it makes more sense to not abbreviate.

Why would the length be an issue? I would understand how it is less pleasant in the code base, for a plugin name it doesn't really matter. Folks reading the plugin name would not understand what "PL" stands for, kind of against the "don't make me think approach".

We should rename the project to Perf Lab 😂

@felixarntz felixarntz removed this from the performance-lab 3.0.0 milestone Mar 21, 2024
@swissspidy swissspidy deleted the add/standalone-plugin-name-prefixing branch May 17, 2024 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Infrastructure Issues for the overall performance plugin infrastructure [Type] Enhancement A suggestion for improvement of an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants