-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Update playground dependencies to v0.9.X #345
Conversation
Would love to be able to use the new version via wp-now 😊 |
I wanted to contribute to this pull request, and have started looking at what's needed to update Playground dependencies from After installing the new versions, there are 29 failing tests. From the error messages and studying the code/tests of PHP-WASM modules, I learned a few things.
My fork of this PR branch shows the progress so far. update/playground-dependencies...eliot-akira:playground-tools:update/playground-dependencies (I wasn't sure if I should create a new pull request, or if this current PR can have multiple authors. I'm guessing the latter is not possible since I don't have write access to the PR branch, update/playground-dependencies.) The tests run a little further now (25 fails) but
One thing I noticed is, the There are a couple places where the code was previously applying a callback to all PHP instances, but the new During the process I learned about Playground CLI (WordPress/wordpress-playground#1289) and the new Boot Protocol (WordPress/wordpress-playground#1390). I can see these are generalizing and modularizing some features of The |
@eliot-akira AFAIR you got all the major changes right. Here's a major non-breaking change that could help with managing workers: |
Thank you, I'll keep chipping away at this. I've continued studying the source of |
OK, I got it down to 3 failing tests. I created a new pull request from my forked branch, since the scope is narrower than this one (update |
Great work @eliot-akira ! 🙌 , thanks for helping on this. I'm back from holidays and catching up. I'll review the PR in the next days. |
What?
Let's update Playground dependencies to the latest version.
We may need to update other projects like Playground Plugin.
Why?
It will fix WBEP images, support curl and other fixes features introduced in these versions.
How?
Testing Instructions
npx nx build wp-now && node dist/packages/wp-now/cli.js start