wp-now: add wp-admin redirection with trailing slash #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamziel
reviewed
Jun 2, 2023
packages/wp-now/src/start-server.ts
Outdated
| @@ -33,6 +33,16 @@ const requestBodyToString = async (req) => | |||
| }); | |||
| }); | |||
|
|
|||
| function addTrailingSlash(path) { | |||
| return (req, res, next) => { | |||
| if (req.url === path) { | |||
There was a problem hiding this comment.
Will that work if the URL is /wp-admin?a=b?
There was a problem hiding this comment.
I tested and it does not.
Maybe addTrailingSlash should be a standalone function with tests, and then we should have some other function for this middleware.
There was a problem hiding this comment.
- Now it supports get parameters
/wp-admin?a=b - I moved the function to a new file, and included tests.
danielbachhuber
approved these changes
Jun 2, 2023
johnhooks
pushed a commit
to johnhooks/playground-tools
that referenced
this pull request
Oct 11, 2024
Document the public and private APIs of all the packages in this repository. This commit is polluted with code refactoring since many ideas stood out as overly complex while writing the docs. There isn't much value in separating them out at this point so they're here. Follow-up work: * Iterate on the docs, fix typos, gather more feedback, reword confusing fragments. * Generate a proper reference doc in a markdown format. It should include the top-level module documentation, function documentation, and the classes + their methods. I'm not sure which tool can handle that correctly. * Add the missing `wordpress-wasm` module documentation * Fill-in any remaining blanks
johnhooks
pushed a commit
to johnhooks/playground-tools
that referenced
this pull request
Oct 11, 2024
This PR populates /docs with a step-by-step documentation connecting the priors documentation efforts shipped in: * API Reference documentation WordPress#63 * Migrate the project to TypeScript WordPress#61 * Add developer documentation WordPress#60 * Monorepo WordPress#57
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
It adds a redirection to
/wp-adminto add the trailing slash/wp-admin/so core loads the correct links in the sidebar.Why?
How?
I created a middleware to add trailing slash given a path.
Testing Instructions
npx nx build wp-nownode dist/packages/wp-now/main.js starthttp://127.0.0.1:8881/wp-admin(without the last slash)http://127.0.0.1:8881/wp-admin/and the sidebar menu has the correct links.